Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-10490: [C++][GLib] Fix range-loop-analysis warnings #8587

Closed
wants to merge 1 commit into from
Closed

ARROW-10490: [C++][GLib] Fix range-loop-analysis warnings #8587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions c_glib/arrow-glib/reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,7 +1184,7 @@ garrow_csv_read_options_add_schema(GArrowCSVReadOptions *options,
{
auto priv = GARROW_CSV_READ_OPTIONS_GET_PRIVATE(options);
auto arrow_schema = garrow_schema_get_raw(schema);
for (const auto field : arrow_schema->fields()) {
for (const auto &field : arrow_schema->fields()) {
priv->convert_options.column_types[field->name()] = field->type();
}
}
Expand All @@ -1206,7 +1206,7 @@ garrow_csv_read_options_get_column_types(GArrowCSVReadOptions *options)
g_str_equal,
g_free,
g_object_unref);
for (const auto iter : priv->convert_options.column_types) {
for (const auto &iter : priv->convert_options.column_types) {
auto arrow_name = iter.first;
auto arrow_data_type = iter.second;
g_hash_table_insert(types,
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/plasma/protocol.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ Status ReadListReply(const uint8_t* data, size_t size, ObjectTable* objects) {
DCHECK(data);
auto message = flatbuffers::GetRoot<fb::PlasmaListReply>(data);
DCHECK(VerifyFlatbuffer(message, data, size));
for (auto const& object : *message->objects()) {
for (auto const object : *message->objects()) {
ObjectID object_id = ObjectID::from_binary(object->object_id()->str());
auto entry = std::unique_ptr<ObjectTableEntry>(new ObjectTableEntry());
entry->data_size = object->data_size();
Expand Down