ARROW-11209: [Rust] DF - Better error message on unsupported GROUP BY #9163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ovr could you write a more descriptive PR description? The PR description becomes the commit message when the PR is merged so we want it to explain exactly what the change is/was. Thanks! |
andygrove
approved these changes
Jan 11, 2021
ovr
changed the title
|
Thanks, @andygrove, for the notice. I've updated the description, and I will use a more useful description in my PRs. |
|
BTW @ovr I am not sure what type you were grouping on, but I had started working on support for String dictionary support for grouping but have gotten distracted. Just FYI -- please don't feel like you need to change what you are working on I just wanted to throw that out there. |
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
I am getting error without details which type is not supported inside GROUP BY: External error: Arrow error: External error: Internal error: Unsupported GROUP BY data type. I added the column's DataType to the error message to make the investigation easier. Closes apache#9163 from ovr/issue-11209 Authored-by: Dmitry Patsura <zaets28rus@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am getting error without details which type is not supported inside GROUP BY:
External error: Arrow error: External error: Internal error: Unsupported GROUP BY data type.
I added the column's DataType to the error message to make the investigation easier.