fix TestIdl to pass on windows #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>
gszadovszky
approved these changes
Sep 20, 2016
|
This is AVRO-1581 |
|
@gszadovszky did you happen to get to run through this on a windows box? It'll take me a bit longer to dig up my windows test laptop. |
|
@busbey I don't have a windows test environment, unfortunately. (Not even a windows test laptop hidden somewhere :) ) |
|
Hello, I am part of a small group trying to get all the pending PRs reviewed. I tested and merged an exact fix contributed in a different PR (sorry I was not aware of this one). |
iemejia
pushed a commit
that referenced
this pull request
Jun 11, 2021
* Make writer block size configurable * Call block_size method in test Co-authored-by: Antonio Uccio Verardi <antonio.uccio.verardi@gmail.com>
SingingBush
pushed a commit
to SingingBush/avro
that referenced
this pull request
Jun 29, 2023
Update to Avro 1.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for some of the avdl input files for the test the copyright statement is picked up as the doc string. when generating jackson escapes \n and \r characters, resulting in a doc string that contains the 2 characters '' followed by 'r' instead of '\r'. the test tries to strip out \r to "normalize" \r\n into \n, but the input actually contains '' 'r' '' 'n', causing the test to fail on windows.
Signed-off-by: radai-rosenblatt radai.rosenblatt@gmail.com