Avro 1605 - Remove Jackson classes from public API #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 28, 2016 09:59
gszadovszky
changed the title
added 2 commits
September 29, 2016 18:35
|
Updated with latest on master, squashed, and now on master. Thanks! |
iemejia
referenced
this pull request
in iemejia/avro
May 24, 2021
* Move from failure to thiserror Closes #115 This is still a WIP branch, with lots of TODOs and some things about thiserror I still can't wrap my head around. However, the heavy-lifting is done, the failure crate has been removed from the list of dependencies and compilation, tests, benchmarks and linting are all green. The two biggest things I have yet to figure out are: 1. How to deal with the errors manually defined in ser.rs and de.rs: they are publicly available and as soon as I touch anything I hit cryptic serde errors 2. How to make errors like TryFromIntError part of more abstract ones like ParseSchemaError, which could have a source error or just a String description. * Update tests/io.rs Co-authored-by: Joel Höner <joel@zyantific.com> * Renaming errors + apply clippy consistently Rename AvroError to Error Removed redundant Error suffix from variants Introduce AvroResult shorthand alias with crate visibility Align clippy invocation in tests with the one in pre-commits * Stop stressing about generic errors and add a couple more sprecific ones * Centralize Ser and De errors into Error The trick was implementing the ser::Error and de::Error trait for crate::errors::Error and return Error::Ser and Error::De variants in the implementation of the custom() method. * SnappyCdcError as struct for consistency * Update CHANGELOG * Update CHANGELOG, README and add a Migration Guide page Co-authored-by: Joel Höner <joel@zyantific.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tightened the visibility level of all public methods which leaks Jackson classes (private or package private). In case of the related method was accessed from outside the package the corresponding public static method of the class
org.apache.avro.util.internal.Accessoris used.Sorry for the big patch but it was easier to develop the whole at once.