Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to 1.13.0-SNAPSHOT #3076

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Move to 1.13.0-SNAPSHOT #3076

merged 5 commits into from
Aug 15, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Aug 8, 2024

Now 1.12.0 has been released 🥳

What is the purpose of the change

(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)

Verifying this change

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Extended interop tests to verify consistent valid schema names between SDKs
  • Added test that validates that Java throws an AvroRuntimeException on invalid binary data
  • Manually verified the change by building the website and checking the new redirect

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@Fokko Fokko changed the title Move to 1.13.0-SNAPSHOT Move to 1.13.0-SNAPSHOT Aug 8, 2024
@github-actions github-actions bot added Java Pull Requests for Java binding build JS labels Aug 8, 2024
@martin-g
Copy link
Member

martin-g commented Aug 8, 2024

Most of the other projects use the contents of .../share/VERSION.txt but only the JS SDK does not! Let's also touch lang/js/package.json

@martin-g
Copy link
Member

martin-g commented Aug 8, 2024

The Java build fails with the same symptoms as the problems with the Docker based testing for the 1.12.0 release - https://github.com/apache/avro/actions/runs/10302739342/job/28517089604?pr=3076
The Maven archetype does not see the 1.13.0-SNAPSHOT artifacts in the reactoer build.

@Fokko
Copy link
Contributor Author

Fokko commented Aug 8, 2024

@martin-g The package.json is already updated: https://github.com/apache/avro/pull/3076/files#diff-4390897d44bcb4480050fea93917b5f82e63877c33832bfd3262528ab4f761b6R3

@Fokko
Copy link
Contributor Author

Fokko commented Aug 8, 2024

It looks like there are nightly builds available:

image

But this looks like a chicken and egg situation :/

Same as apache@3a8b91f but for Java ARM workflow

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Copy link
Contributor Author

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just giving this a try, when it works I'll come up with a cleaner solution

@martin-g martin-g merged commit 38321e6 into apache:main Aug 15, 2024
16 checks passed
@Fokko Fokko deleted the fd-bump-to-next-version branch August 15, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Java Pull Requests for Java binding JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants