AVRO-4042: [java] Precache ObjectMapper to avoid recreation #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObjectMapper is an expensive, immutable and thread-safe object. By creating just one instance, we can avoid unnecessary recalculations.
martin-g
approved these changes
Aug 27, 2024
bgalek
approved these changes
Aug 27, 2024
opwvhk
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
ObjectMapper is an expensive, thread-safe object. By creating just one instance, we can avoid unnecessary recalculations.
Verifying this change
(Please pick one of the following options)
This change is already covered by existing tests, such as
TestJacksonUtilsorTestSchemaBuilderDocumentation