Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataclasses to perf alert tool and refactor code. #28889

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

AnandInguva
Copy link
Contributor

Fixes: #28395

Groups the variables in Dataclasses for better readability and extensibility


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #28889 (b312e05) into master (a3bf007) will decrease coverage by 0.07%.
Report is 2 commits behind head on master.
The diff coverage is 1.63%.

@@            Coverage Diff             @@
##           master   #28889      +/-   ##
==========================================
- Coverage   72.23%   72.16%   -0.07%     
==========================================
  Files         685      686       +1     
  Lines      101519   101551      +32     
==========================================
- Hits        73329    73286      -43     
- Misses      26612    26687      +75     
  Partials     1578     1578              
Flag Coverage Δ
python 82.61% <1.63%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/python/apache_beam/testing/analyzers/__init__.py 100.00% <100.00%> (ø)
...ache_beam/testing/analyzers/github_issues_utils.py 0.00% <0.00%> (-40.91%) ⬇️
...hon/apache_beam/testing/analyzers/perf_analysis.py 16.21% <0.00%> (-0.69%) ⬇️
...ache_beam/testing/analyzers/perf_analysis_utils.py 13.84% <0.00%> (-4.61%) ⬇️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@liferoad
Copy link
Collaborator

liferoad commented Oct 9, 2023

Do we need to merge this PR to test whether it works or Performance alerting tool on Python load/performance/benchmark tests already tested it?

@AnandInguva
Copy link
Contributor Author

This PR is just mostly refactoring. The unit tests tested the code. I tested the tool locally as well.

Copy link
Collaborator

@liferoad liferoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix the precommit.

@AnandInguva AnandInguva changed the title Add dataclasses to perf aler tool and refactor code. Add dataclasses to perf alert tool and refactor code. Oct 9, 2023
@AnandInguva AnandInguva merged commit 6046297 into apache:master Oct 9, 2023
88 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Support NamedTuples/Dataclass for perf alert tests configuration
2 participants