-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dataclasses to perf alert tool and refactor code. #28889
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28889 +/- ##
==========================================
- Coverage 72.23% 72.16% -0.07%
==========================================
Files 685 686 +1
Lines 101519 101551 +32
==========================================
- Hits 73329 73286 -43
- Misses 26612 26687 +75
Partials 1578 1578
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @liferoad for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Do we need to merge this PR to test whether it works or Performance alerting tool on Python load/performance/benchmark tests already tested it? |
This PR is just mostly refactoring. The unit tests tested the code. I tested the tool locally as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please fix the precommit.
Fixes: #28395
Groups the variables in Dataclasses for better readability and extensibility
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.