Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stuck Test]: GitHub Action issue_comment trigger not scalable #28909

Open
16 tasks
Abacn opened this issue Oct 10, 2023 · 3 comments
Open
16 tasks

[Stuck Test]: GitHub Action issue_comment trigger not scalable #28909

Abacn opened this issue Oct 10, 2023 · 3 comments
Labels
bug failing test github_actions Pull requests that update GitHub Actions code P2 permared tests

Comments

@Abacn
Copy link
Contributor

Abacn commented Oct 10, 2023 •
edited
Loading

What happened?

See https://github.com/apache/beam/actions?page=100

We are experiencing a huge queue of GHA tests. Current phrase trigger is not scalable - every issue comments triggers hundreds of jobs. This become especially problematic when a mass commit script is running

Issue Failure

Failure: Test is continually failing

Issue Priority

Priority: 2

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@Abacn Abacn mentioned this issue Oct 10, 2023
Merged
3 tasks
@Abacn
Copy link
Contributor Author

Abacn commented Oct 10, 2023

An issue is that when this happens, it's queued in GitHub side, even before the queue for self-hosted runners, so no check show in the PR, which may be confusing and merge code before the check run (which happened before)

@Abacn
Copy link
Contributor Author

Abacn commented Oct 10, 2023

We have reduced 64 issue_comment triggers, downgrade this to P2 for a long term solution

@Abacn Abacn changed the title [Failing Test]: GitHub Action jobs not triggering [Failing Test]: GitHub Action issue_comment trigger not scalable Oct 10, 2023
@Abacn Abacn changed the title [Failing Test]: GitHub Action issue_comment trigger not scalable [Stuck Test]: GitHub Action issue_comment trigger not scalable Oct 10, 2023
@Abacn Abacn added P2 github_actions Pull requests that update GitHub Actions code and removed awaiting triage labels Oct 10, 2023
@AnandInguva AnandInguva mentioned this issue Oct 10, 2023
Merged
3 tasks
@Abacn
Copy link
Contributor Author

Abacn commented Oct 10, 2023 •
edited
Loading

This still persists, now the action queue is more than 1 hr old.

@Abacn Abacn added P1 and removed P2 labels Oct 10, 2023
@Abacn Abacn mentioned this issue Oct 10, 2023
Merged
3 tasks
@Abacn Abacn removed the P2 label Oct 10, 2023
This was referenced Oct 10, 2023
Merged
Merged
Merged
@Abacn Abacn added P2 and removed P1 labels Oct 17, 2023
@Abacn Abacn mentioned this issue Oct 17, 2023
Merged
3 tasks
@Abacn Abacn mentioned this issue Nov 28, 2023
Merged
3 tasks
@tvalentyn tvalentyn mentioned this issue Apr 12, 2024
Merged
@Abacn Abacn mentioned this issue May 6, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug failing test github_actions Pull requests that update GitHub Actions code P2 permared tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Abacn