-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable comment trigger for Performance and Load Tests #29035
Disable comment trigger for Performance and Load Tests #29035
Conversation
Yes, for Perf and Load tests (and postcommits that have Jenkins counterpart). Until we replaced the comment trigger the precommit issue_comment triggered are kept because PR testing are most likely need them, and the number of precommit is tolerable for the queueing issue described in #28909 |
Notice that the tests that this PR involves are mostly newly added workflows after #28915 |
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Hello, thanks for checking |
.github/workflows/beam_PostCommit_Java_IO_Performance_Tests.yml
Outdated
Show resolved
Hide resolved
* reference PR 28915 issue_comment removed * post commit issue_comment fix * revert changes for postcommit
Reference PR https://github.com/apache/beam/pull/28915/files issue_comment removed
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.