Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable comment trigger for Performance and Load Tests #29035

Conversation

magicgoody
Copy link
Contributor

Reference PR https://github.com/apache/beam/pull/28915/files issue_comment removed


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Oct 17, 2023
@andreydevyatkin
Copy link
Collaborator

andreydevyatkin commented Oct 17, 2023

@Abacn Shall we disable comment trigger for Perf and Load tests only or for all workflows? Not sure if we actually need to disable it, but I see you started doing it here: #28915

@Abacn
Copy link
Contributor

Abacn commented Oct 17, 2023

@Abacn Shall we disable comment trigger for Perf and Load tests only or for all workflows? Not sure if we actually need to disable it, but I see you started doing it here: #28915

Yes, for Perf and Load tests (and postcommits that have Jenkins counterpart). Until we replaced the comment trigger the precommit issue_comment triggered are kept because PR testing are most likely need them, and the number of precommit is tolerable for the queueing issue described in #28909

@Abacn
Copy link
Contributor

Abacn commented Oct 17, 2023

Notice that the tests that this PR involves are mostly newly added workflows after #28915

@magicgoody magicgoody marked this pull request as ready for review October 17, 2023 23:58
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@magicgoody magicgoody marked this pull request as draft October 18, 2023 01:20
@magicgoody magicgoody marked this pull request as ready for review October 18, 2023 11:00
@magicgoody
Copy link
Contributor Author

@Abacn Shall we disable comment trigger for Perf and Load tests only or for all workflows? Not sure if we actually need to disable it, but I see you started doing it here: #28915

Yes, for Perf and Load tests (and postcommits that have Jenkins counterpart). Until we replaced the comment trigger the precommit issue_comment triggered are kept because PR testing are most likely need them, and the number of precommit is tolerable for the queueing issue described in #28909

Hello, thanks for checking
I also removed such workflow trigger for 4 PostCommit jobs where part of Jenkins is not yet disabled.

@Abacn Abacn merged commit 91207bc into apache:master Oct 19, 2023
4 checks passed
kkdoon pushed a commit to twitter-forks/beam that referenced this pull request Oct 21, 2023
* reference PR 28915 issue_comment removed

* post commit issue_comment fix

* revert changes for postcommit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants