[BEAM-22] Use an explicit coder in XmlSourceTest #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard coder for an XML source is the JAXBCoder, which is not suitable as part of a composite coder.
|
R: @bjchambers |
|
@dhalperi for discussion. If |
|
LGTM, will merge pending discussion. |
| PCollection<Train> output = p.apply(Read.from(source).named("ReadFileData")); | ||
| AvroCoder<Train> intermediateCoder = AvroCoder.of(Train.class); | ||
| PCollection<Train> output = | ||
| p.apply(Read.from(source).named("ReadFileData")).setCoder(intermediateCoder); |
There was a problem hiding this comment.
please update to the happy apply syntax (aka, drop 'named').
|
R: @dhalperi so the scripts pick it up. |
|
Please put |
tgroh
changed the title
|
My main comment is that we should probably fix JAXBCoder to behave correctly in inner context. That is backwards-incompatible, but it fixes a bug that is probably causing crashes if users are using it this way. |
|
R: @davorbonaci to comment on backwards-incompatible change. |
4 tasks
|
Replaced by #116 |
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
apache#13 [euphoria-flink] Batch executor uses hash code as a key in shufflles
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
* refactor: remove async unit test nox session * refactor: remove async unit test directory * fix: noxfile unit test imports and arglist
xinyuiscool
pushed a commit
to xinyuiscool/beam
that referenced
this pull request
Feb 28, 2024
SQL PTransform Update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
number, if there is one.
Individual Contributor License Agreement.
The standard coder for an XML source is the JAXBCoder, which is not
suitable as part of a composite coder.
This is required for [BEAM-22], due to the implementation of
CreatePCollectionView.