Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13590]Add support for python 3.10 #17700

Closed
wants to merge 47 commits into from

Conversation

AnandInguva
Copy link
Contributor

@AnandInguva AnandInguva commented May 18, 2022

Add Python 3.10 infrastructure and test suites

Fixes: #21971
Fixes: #21458
FIxes: #21671


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #17700 (e7504b4) into master (3ffdf8d) will decrease coverage by 1.06%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master   #17700      +/-   ##
==========================================
- Coverage   73.40%   72.34%   -1.07%     
==========================================
  Files         719      719              
  Lines       95940    95933       -7     
==========================================
- Hits        70424    69400    -1024     
- Misses      24205    25222    +1017     
  Partials     1311     1311              
Flag Coverage Δ
python 81.61% <83.33%> (-1.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ython/apache_beam/runners/interactive/sql/utils.py 76.09% <ø> (ø)
sdks/python/apache_beam/typehints/row_type.py 100.00% <ø> (ø)
...apache_beam/typehints/native_type_compatibility.py 85.52% <33.33%> (-1.06%) ⬇️
sdks/python/apache_beam/typehints/opcodes.py 85.35% <50.00%> (-0.26%) ⬇️
.../python/apache_beam/typehints/trivial_inference.py 96.15% <87.50%> (-0.27%) ⬇️
sdks/python/apache_beam/__init__.py 85.00% <100.00%> (ø)
...apache_beam/runners/dataflow/internal/apiclient.py 77.34% <100.00%> (ø)
...s/python/apache_beam/typehints/sharded_key_type.py 93.54% <100.00%> (ø)
sdks/python/apache_beam/typehints/typehints.py 93.37% <100.00%> (-0.06%) ⬇️
...i/org/apache/beam/model/pipeline/v1/metrics_pb2.py 21.08% <0.00%> (-78.92%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnandInguva
Copy link
Contributor Author

Run Python PreCommit

1 similar comment
@AnandInguva
Copy link
Contributor Author

Run Python PreCommit

@aaltay
Copy link
Member

aaltay commented Jun 9, 2022

What is the next step on this PR?

@AnandInguva
Copy link
Contributor Author

What is the next step on this PR?

There are type hint related bugs. I will do more investigation next week and try to find the solution or ask help.

@robertwb
Copy link
Contributor

Is this still being worked on? Are there intermediate milestones that could be checked in sooner rather than later?

@AnandInguva
Copy link
Contributor Author

Is this still being worked on? Are there intermediate milestones that could be checked in sooner rather than later?

Yes, it is still being worked on. There are some blockers and we filed GH issues on them.

@AnandInguva
Copy link
Contributor Author

Run Python 3.10 PostCommit

@AnandInguva AnandInguva marked this pull request as ready for review October 9, 2022 02:08
@AnandInguva
Copy link
Contributor Author

@tvalentyn Can you enable the gh workflow?

@AnandInguva
Copy link
Contributor Author

Run Python Dataflow ValidatesRunner

@AnandInguva
Copy link
Contributor Author

Run Python Dataflow ValidatesContainer

@AnandInguva
Copy link
Contributor Author

Run Python Dataflow ValidatesRunner

@AnandInguva
Copy link
Contributor Author

Run Python Dataflow V2 ValidatesRunner

@AnandInguva
Copy link
Contributor Author

Run Python Examples_Direct

@AnandInguva
Copy link
Contributor Author

Run Python 3.10 PostCommit

@tvalentyn
Copy link
Contributor

@tvalentyn Can you enable the gh workflow?

I clicked the button to approve the run, lmk if other action is necessary.

@tvalentyn tvalentyn closed this Oct 20, 2022
@aaltay
Copy link
Member

aaltay commented Oct 20, 2022

Was this merged?

@AnandInguva
Copy link
Contributor Author

AnandInguva commented Oct 21, 2022

Yes. These changes were merged in a different PR - #23587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants