-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-13590]Add support for python 3.10 #17700
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #17700 +/- ##
==========================================
- Coverage 73.40% 72.34% -1.07%
==========================================
Files 719 719
Lines 95940 95933 -7
==========================================
- Hits 70424 69400 -1024
- Misses 24205 25222 +1017
Partials 1311 1311
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
99a99f3
to
8006cf1
Compare
Run Python PreCommit |
1 similar comment
Run Python PreCommit |
What is the next step on this PR? |
There are type hint related bugs. I will do more investigation next week and try to find the solution or ask help. |
262f453
to
e7ce225
Compare
2042c70
to
47e9bf9
Compare
Is this still being worked on? Are there intermediate milestones that could be checked in sooner rather than later? |
Yes, it is still being worked on. There are some blockers and we filed GH issues on them. |
47e9bf9
to
308288f
Compare
Run Python 3.10 PostCommit |
@tvalentyn Can you enable the gh workflow? |
Run Python Dataflow ValidatesRunner |
Run Python Dataflow ValidatesContainer |
Run Python Dataflow ValidatesRunner |
Run Python Dataflow V2 ValidatesRunner |
Run Python Examples_Direct |
Run Python 3.10 PostCommit |
I clicked the button to approve the run, lmk if other action is necessary. |
Was this merged? |
Yes. These changes were merged in a different PR - #23587 |
Add Python 3.10 infrastructure and test suites
Fixes: #21971
Fixes: #21458
FIxes: #21671
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.