Feature/name all java threads #23387
Conversation
…nto feature/name_all_java_threads # Conflicts: # CHANGES.md
…nto feature/name_all_java_threads
|
Assigning reviewers. If you would like to opt out of this review, comment R: @apilloud for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Run Java Precommit |
|
It looks like this is still failing quite a few spotless checks. Can you run :spotlessApply on the failing packages? See output here: https://ci-beam.apache.org/job/beam_PreCommit_Spotless_Commit/22861/console |
There was a problem hiding this comment.
LGTM minus one format change and the spotless test failures.
I have no strong opinions about the thread names, but ccing some people who might.
cc: @kennknowles @lukecwik
...tion/src/main/java/org/apache/beam/runners/fnexecution/control/BundleCheckpointHandlers.java
Outdated
Show resolved
Hide resolved
|
i don't understand why the pre commit runs successful on my machine and not with gitactions. |
|
Run Java PreCommit |
|
I did a couple times and i do not get any error. |
|
We have flakes that show up and fail precommit runs. Also my comment above was to launch the test suite again since that is how Jenkins is integrated with Github for Apache Beam |
|
Run Java PreCommit |
|
fixes #23049 |
Name all Java threads to aid in debugging #23049
R: @kennknowles for label java.
R: @Abacn for label io.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.