-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Playground] Use current Go SDK by default #24256
Merged
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0363c48
gradle-cache
eantyshev 543755d
python
eantyshev 9f5c7ea
SDK_TAG
eantyshev cd76056
fix
eantyshev d3108ee
java
eantyshev 92c9513
only python
eantyshev a1e4b27
write cache
eantyshev b04a370
go
eantyshev c885ed8
AIO
eantyshev 401f5af
python
eantyshev 328c2ab
nit
eantyshev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
#!/bin/bash -uex | ||
# Licensed to the Apache Software Foundation (ASF) under one or more | ||
# contributor license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright ownership. | ||
# The ASF licenses this file to You under the Apache License, Version 2.0 | ||
# (the "License"); you may not use this file except in compliance with | ||
# the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
# Usage: ./setup_sdk.sh /opt/playground/prepared_folder | ||
# Setup Go Beam SDK dev environment, so that examples' dependencies were met. | ||
# Consumed envs: | ||
# - PREPARED_MOD_DIR: result module path | ||
# - SDK_TAG: desired SDK version, for ex. "2.42.0", "2.44.0dev" | ||
# - SDK_TAG_LOCAL: special value for SDK_TAG for the local Go SDK (defined by build system) | ||
# - BEAM_SRC: Go SDK location | ||
|
||
PIPELINES_MODULE="executable_files" | ||
|
||
# Project convention for local versions 2.44.0.dev is incorrect in Go | ||
# Replace this with 2.44.0-dev | ||
SDK_TAG=${SDK_TAG/%.dev/-dev} | ||
SDK_TAG_LOCAL=${SDK_TAG_LOCAL/%.dev/-dev} | ||
|
||
mkdir -p $PREPARED_MOD_DIR | ||
cd $PREPARED_MOD_DIR | ||
|
||
BEAM_PKG=github.com/apache/beam/sdks/v2 | ||
|
||
go mod init $PIPELINES_MODULE | ||
go mod edit -require=$BEAM_PKG@v$SDK_TAG | ||
|
||
if [ "$SDK_TAG" == "$SDK_TAG_LOCAL" ]; then | ||
go mod edit -replace=$BEAM_PKG@v$SDK_TAG=$BEAM_SRC | ||
fi | ||
|
||
go get -x $BEAM_PKG/go/pkg/beam@v$SDK_TAG | ||
go get -x $BEAM_PKG/go/test/integration@v$SDK_TAG | ||
|
||
go mod download -x all |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we actually only fixing a bug which rewrites previous build args and makes only SDK_TAG visible