-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Go SDK]: Infer field names from struct tags #24473
[Go SDK]: Infer field names from struct tags #24473
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24473 +/- ##
=======================================
Coverage 73.36% 73.37%
=======================================
Files 718 719 +1
Lines 97165 97185 +20
=======================================
+ Hits 71287 71310 +23
+ Misses 24531 24528 -3
Partials 1347 1347
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
R: @lostluck |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for clearing out that TODO!
Please note that neither of those two IOs are currently incredibly performant. They work, but they are unable to scale to multiple machines presently. I go into why a bit in a recent reply: #24364 (comment)
Run Go PostCommit |
Thanks for the reference! I was thinking of developing a new IO connector and will bear it in mind |
Implements a function
structx.InferFieldNames
which takes a struct type and a tag key, and returns a slice of field names based on this. Fixes #24465.Updates
bigqueryio.Read
andspannerio.Read
to make use ofstructx.InferFieldNames
when constructing select statements.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.