Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go SDK] Exec changes for timer support #24692

Closed
wants to merge 5 commits into from

Conversation

riteshghorse
Copy link
Contributor

This PR adds changes to exec package without fn-invocation part
Part of #22737


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the go label Dec 16, 2022
@riteshghorse
Copy link
Contributor Author

stop reviewer notifications

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: requested by reviewer

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #24692 (bd700d8) into master (aa6cc16) will increase coverage by 0.10%.
The diff coverage is 55.35%.

@@            Coverage Diff             @@
##           master   #24692      +/-   ##
==========================================
+ Coverage   73.34%   73.44%   +0.10%     
==========================================
  Files         719      752      +33     
  Lines       97169   102380    +5211     
==========================================
+ Hits        71268    75196    +3928     
- Misses      24552    25715    +1163     
- Partials     1349     1469     +120     
Flag Coverage Δ
go 55.11% <55.35%> (+3.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/runtime/exec/data.go 0.00% <ø> (ø)
sdks/go/pkg/beam/core/runtime/exec/translate.go 23.14% <0.00%> (+5.94%) ⬆️
sdks/go/pkg/beam/core/runtime/exec/timers.go 41.07% <41.07%> (ø)
sdks/go/pkg/beam/core/runtime/exec/pardo.go 60.07% <100.00%> (+0.47%) ⬆️
sdks/go/pkg/beam/core/timers/timers.go 100.00% <100.00%> (ø)

... and 62 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 18, 2023
@github-actions
Copy link
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Feb 25, 2023
@riteshghorse riteshghorse reopened this Mar 16, 2023
@github-actions github-actions bot removed the stale label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant