-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PipelineOptions
for constructing BigQueryWrapper
when estimating BigQuery table size (#26622)
#26662
Conversation
BigQueryWrapper
factory method with PipelineOptions
(#26622)PipelineOptions
in BigQueryWrapper
when estimating _BigQuery_ table size (#26622)
PipelineOptions
in BigQueryWrapper
when estimating _BigQuery_ table size (#26622)PipelineOptions
for constructing BigQueryWrapper
when estimating BigQuery table size (#26622)
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch!
For the Format check fail, run this command to fix:
|
waiting on author |
Codecov Report
@@ Coverage Diff @@
## master #26662 +/- ##
==========================================
- Coverage 72.06% 71.93% -0.14%
==========================================
Files 745 747 +2
Lines 101200 101467 +267
==========================================
+ Hits 72930 72986 +56
- Misses 26810 27021 +211
Partials 1460 1460
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I've reformatted the code as you suggested 🙂 |
Run Python_Runners PreCommit |
Thank you! |
…ing BigQuery table size (apache#26622) (apache#26662) * Add `BigQueryWrapper` factory method with `PipelineOptions` (apache#26622) * Pass `PipelineOptions` to `BigQueryWrapper` when estimating table size (apache#26622) * Reformat `bigquery_tools.py` (apache#26622)
This Pull Request addresses issue #26622.
Changes made:
BigQueryWrapper
that allows for specifyingPipelineOptions
for which the Google Cloud Platform credentials are retrieved for the underlying BigQuery client,PipelineOptions
toBigQueryWrapper
when estimating BigQuery table size.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.