Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider beam_services option when determining the expansion service type #27345

Conversation

chamikaramj
Copy link
Contributor

@chamikaramj chamikaramj commented Jul 3, 2023

This fixes #27346


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the python label Jul 3, 2023
@chamikaramj
Copy link
Contributor Author

R: @bvolpato

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@chamikaramj
Copy link
Contributor Author

@Abacn we either need to cherry-pick this (or revert #27228) to prevent the Google tests from failing when running with the 2.49.0 release.

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #27345 (2c30acf) into master (e8d8043) will increase coverage by 0.01%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master   #27345      +/-   ##
==========================================
+ Coverage   71.22%   71.23%   +0.01%     
==========================================
  Files         854      854              
  Lines      103712   103716       +4     
==========================================
+ Hits        73873    73887      +14     
+ Misses      28292    28282      -10     
  Partials     1547     1547              
Flag Coverage Δ
python 80.58% <42.85%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/external.py 75.66% <25.00%> (-0.42%) ⬇️
sdks/python/apache_beam/utils/subprocess_server.py 58.73% <66.66%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chamikaramj
Copy link
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: beam_services option should be considered when determining the expansion service type
2 participants