[Python] use get_buffer to fetch buffer when the buffer is None #27373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27373 +/- ##
==========================================
- Coverage 71.31% 71.19% -0.12%
==========================================
Files 862 862
Lines 105199 104659 -540
==========================================
- Hits 75025 74516 -509
+ Misses 28624 28593 -31
Partials 1550 1550
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 32 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AnandInguva
changed the title
AnandInguva
commented
Jul 10, 2023
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
Outdated
Show resolved
Hide resolved
|
R: @pabloem cc: @tvalentyn , @liferoad |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
I tested the TFX test mentioned at #25315 (comment). It is working |
liferoad
reviewed
Jul 10, 2023
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
Outdated
Show resolved
Hide resolved
AnandInguva
commented
Jul 10, 2023
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
Outdated
Show resolved
Hide resolved
|
this LGTM! Thanks so much @AnandInguva - can you add a test case? Feel free to merge after adding the test case. |
Done. Test fails without the above change |
liferoad
approved these changes
Jul 11, 2023
|
Lint error is not related to this PR |
aleksandr-dudko
pushed a commit
to aleksandr-dudko/beam
that referenced
this pull request
Jul 17, 2023
…he#27373) * Create empty ListBuffer when buffer is none * Replace empty buffer with a List/GroupBuffer * Apply suggestions from code review * Fix mypy error * Update sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py * Add test * Add note to CHANGES.md * Fix link in CHANGES.md
aleksandr-dudko
pushed a commit
to aleksandr-dudko/beam
that referenced
this pull request
Jul 17, 2023
…ne (apache#27373)" (apache#27491) This reverts commit 63d5171.
Merged
3 tasks
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
May 24, 2024
…he#27373) * Create empty ListBuffer when buffer is none * Replace empty buffer with a List/GroupBuffer * Apply suggestions from code review * Fix mypy error * Update sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py * Add test * Add note to CHANGES.md * Fix link in CHANGES.md
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
May 24, 2024
…ne (apache#27373)" (apache#27491) This reverts commit 63d5171.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25315
Fixes: #23228
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.