Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing python postcommits #27662

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

ahmedabu98
Copy link
Contributor

@ahmedabu98 ahmedabu98 commented Jul 25, 2023

Fixes #27643

@ahmedabu98
Copy link
Contributor Author

R: @riteshghorse
R: @BjornPrime

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@ahmedabu98
Copy link
Contributor Author

Confirmed the fix by running the test bigquery_read_it_test.py::ReadUsingStorageApiTests::test_iobase_source_with_very_selective_filters locally before and after

@riteshghorse
Copy link
Contributor

Run Python 3.11 PostCommit

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #27662 (30383c0) into master (6cd6410) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #27662      +/-   ##
==========================================
- Coverage   70.93%   70.93%   -0.01%     
==========================================
  Files         861      861              
  Lines      104806   104807       +1     
==========================================
  Hits        74341    74341              
- Misses      28907    28908       +1     
  Partials     1558     1558              
Flag Coverage Δ
python 80.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ython/apache_beam/io/gcp/bigquery_read_internal.py 57.89% <100.00%> (+0.20%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@riteshghorse
Copy link
Contributor

Bigquery tests are now passing in Py 3.11 PC.

Other failures are not related to this change. Merging this one!

@riteshghorse riteshghorse merged commit 1273d22 into apache:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing Test]: Python PostCommits are red with failing bigquery test
2 participants