Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize workflow files #27712

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Conversation

Amar3tto
Copy link
Contributor

@Amar3tto Amar3tto commented Jul 27, 2023

All github workflow files were standardized.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Collaborator

@andreydevyatkin andreydevyatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of minor comments, overall LGTM

.github/workflows/beam_PreCommit_Go.yml Outdated Show resolved Hide resolved
@Amar3tto Amar3tto marked this pull request as ready for review July 28, 2023 15:43
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@damccorm
Copy link
Contributor

Ah, this now has conflicts that need to be merged. @Amar3tto would you mind taking a look?

@Amar3tto
Copy link
Contributor Author

Ah, this now has conflicts that need to be merged. @Amar3tto would you mind taking a look?

Thanks for the review!
I have resolved all conflicts.

@damccorm damccorm merged commit 36e8254 into apache:master Jul 31, 2023
3 checks passed
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Aug 1, 2023
* Standardize workflow files

* Fix job names

* Resolve comments

* Fix removing m2/setting.xml
bullet03 pushed a commit to akvelon/beam that referenced this pull request Aug 11, 2023
* Standardize workflow files

* Fix job names

* Resolve comments

* Fix removing m2/setting.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants