Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes to scripts to release multi-arch Beam SDK containers #27836

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

celeste-zeng
Copy link
Contributor

@celeste-zeng celeste-zeng commented Aug 3, 2023

  • Change the default architectures for release containers to be both amd64 and arm64.
  • Change all the dockerPush tasks called by the release pushAll task to be docker instead, since multi-arch containers are pushed during build.
  • Details see the Change the release process to release multi-arch Beam SDK containers section in the doc.
  • Github action test suites that build multi-arch Beam SDK containers:
  1. Python ValidatesContainer Dataflow ARM
  2. PostCommit Go Dataflow ARM
  3. PostCommit Java Examples Dataflow ARM
    Those tests build and push multi-arch Beam SDK containers to us.gcr.io/apache-beam-testing/github-actions.
    The tests will fail for now since the Dataflow service side change is not yet completed, but by checking the repository we can see the multi-arch containers are tagged and pushed properly.

Test suites that test ARM components of the multi-arch containers:

  1. beam_PostCommit_Go_Dataflow_ARM.yml
  2. beam_PostCommit_Java_Examples_Dataflow_ARM.yml
  3. beam_Python_ValidatesContainer_Dataflow_ARM.yml

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #27836 (7bc79c3) into master (fb6d167) will decrease coverage by 0.02%.
Report is 7 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #27836      +/-   ##
==========================================
- Coverage   70.88%   70.87%   -0.02%     
==========================================
  Files         861      861              
  Lines      105001   105001              
==========================================
- Hits        74429    74416      -13     
- Misses      29013    29028      +15     
+ Partials     1559     1557       -2     
Flag Coverage Δ
go 53.72% <ø> (-0.04%) ⬇️
python 79.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.
R: @kennknowles for label java.
R: @lostluck for label go.
R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor

Changes look good to me, cc: @lostluck next release manager. We will need to announce this in CHANGES.md as well.

@tvalentyn
Copy link
Contributor

Please document in PR description which test suites exercise the ARM containers so that other folks can see the status of that before mering.

@celeste-zeng
Copy link
Contributor Author

Run Java_PVR_Flink_Batch PreCommit

@lostluck
Copy link
Contributor

lostluck commented Aug 4, 2023

Changes look good to me, cc: @lostluck next release manager. We will need to announce this in CHANGES.md as well.

Then be sure to send the PR that updates the CHANGES.md before the cut please.

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck
Copy link
Contributor

lostluck commented Aug 4, 2023

Run Go PreCommit

@celeste-zeng
Copy link
Contributor Author

Run Python_Integration PreCommit

@celeste-zeng
Copy link
Contributor Author

Run Java_PVR_Flink_Batch PreCommit

@lostluck
Copy link
Contributor

lostluck commented Aug 8, 2023

@celeste-zeng What actions remain for this?

@tvalentyn tvalentyn merged commit 36f4bd8 into apache:master Aug 8, 2023
89 of 90 checks passed
@celeste-zeng celeste-zeng deleted the release-script-change branch August 9, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants