-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made changes to scripts to release multi-arch Beam SDK containers #27836
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27836 +/- ##
==========================================
- Coverage 70.88% 70.87% -0.02%
==========================================
Files 861 861
Lines 105001 105001
==========================================
- Hits 74429 74416 -13
- Misses 29013 29028 +15
+ Partials 1559 1557 -2
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Changes look good to me, cc: @lostluck next release manager. We will need to announce this in CHANGES.md as well. |
Please document in PR description which test suites exercise the ARM containers so that other folks can see the status of that before mering. |
Run Java_PVR_Flink_Batch PreCommit |
Then be sure to send the PR that updates the CHANGES.md before the cut please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Run Go PreCommit |
Run Python_Integration PreCommit |
Run Java_PVR_Flink_Batch PreCommit |
@celeste-zeng What actions remain for this? |
Those tests build and push multi-arch Beam SDK containers to
us.gcr.io/apache-beam-testing/github-actions
.The tests will fail for now since the Dataflow service side change is not yet completed, but by checking the repository we can see the multi-arch containers are tagged and pushed properly.
Test suites that test ARM components of the multi-arch containers:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.