Change pd.core.strings.StringMethods for Pandas 2 compatability. #28455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 69df894.
|
R: @tvalentyn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #28455 +/- ##
========================================
Coverage 72.33% 72.33%
========================================
Files 682 683 +1
Lines 100536 100801 +265
========================================
+ Hits 72719 72915 +196
- Misses 26239 26308 +69
Partials 1578 1578
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
caneff
force-pushed
the
string_methods
branch
2 times, most recently
from
d5b2d40
to
8caa171
Compare
In Pandas 2, pd.Series.str is the right way and still works with Pandas 1
caneff
force-pushed
the
string_methods
branch
from
9e7927c
to
9358eb5
Compare
tvalentyn
reviewed
Sep 15, 2023
|
Run Python_PVR_Flink PreCommit |
|
Run Python_Runners PreCommit |
1 similar comment
|
Run Python_Runners PreCommit |
|
Run Python PreCommit |
|
Run Python_PVR_Flink PreCommit |
|
Run Python PreCommit |
tvalentyn
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new way to do it is
pd.Series.strand it is identical functionality.Umbrella issue: #27221