[YAML] Java PubSubIO #28782
[YAML] Java PubSubIO #28782
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
R: @chamikaramj |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Ping on this PR. |
...tform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubReadSchemaTransformProvider.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| @SuppressWarnings({ | ||
| "nullness" // TODO(https://github.com/apache/beam/issues/20497) |
There was a problem hiding this comment.
Can we fix nullness errors and remove this suppression ?
There was a problem hiding this comment.
Unfortunately not, as all the row.getXxx() methods may be null (but are only used in contexts where they should not be). I did try to keep the nullness suppression local rather than decorating the whole class though.
...form/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubWriteSchemaTransformProvider.java
Outdated
Show resolved
Hide resolved
...m/src/test/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubReadSchemaTransformProviderTest.java
Outdated
Show resolved
Hide resolved
...tform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubReadSchemaTransformProvider.java
Outdated
Show resolved
Hide resolved
| return pubsubRead; | ||
| } | ||
|
|
||
| @Override | ||
| public PCollectionRowTuple expand(PCollectionRowTuple input) { | ||
| PubsubIO.Read<PubsubMessage> pubsubRead = buildPubsubRead(); | ||
| @SuppressWarnings("nullness") |
There was a problem hiding this comment.
Is this suppression needed ?(if so probably can be removed by adding a null check before this line).
There was a problem hiding this comment.
Unfortunately the nullness checker is not smart enough for that.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.