-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clickhouse support low cardinality #29533
Clickhouse support low cardinality #29533
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
I do not think this failure is related to my implementation |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me. Had a comment about documentaion
@@ -111,7 +111,9 @@ | |||
* <tr><td>{@link TableSchema.TypeName#BOOL}</td> <td>{@link Schema.TypeName#BOOLEAN}</td></tr> | |||
* </table> | |||
* | |||
* Nullable row columns are supported through Nullable type in ClickHouse. | |||
* Nullable row columns are supported through Nullable type in ClickHouse. Adding support for <a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is javadoc. The statement "Adding support ..." sounds like an announcement and consider moving it to CHANGES.md
For here, consider phrasing like "Low cardinality hint is supported through LowCardinality DataType in ClickHouse."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM, will merge once tests passed
Co-authored-by: Yi Hu <huuyyi@gmail.com>
Support for LowCardinality for ClickHouse.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.