[Python] Enrichment Transform v1 #29782
Conversation
|
Run Python_Integration PreCommit 3.8 |
|
Run Python 3.9 PostCommit |
|
Run Python 3.8 PostCommit |
|
Run Python 3.11 PostCommit |
|
Run Python 3.11 PostCommit |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
R: @damccorm (since Cham is OOO until new year's). No rush though! |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
| test_pipeline | ||
| | 'Create PCollection' >> beam.Create([req]) | ||
| | 'Enrichment Transform' >> Enrichment(client)) | ||
| self.assertIsNotNone(output) |
There was a problem hiding this comment.
I think we should have some more extensive testing here. Specifically:
- We should test that the join works (so this should validate the output pcollection)
- We should test a custom join
I'd feel even better if we could validate some of the other behaviors (e.g. retry strategy) so that from an interface perspective we could swap out rrio and be confident everything works if needed, though that is not required if difficult
There was a problem hiding this comment.
Should be doable within this PR itself. I'll add that!
|
Run Python 3.8 PostCommit |
|
CC: @robertwb (I had a offline chat with Robert. It would be to good to have the params as declarative and beam.Row as input/output type for cross-lang usage. I'll have that changes with Throttler in next PR.) |
Implemented enrichment transform
Part of #29787
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.