Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate external transform wrappers using a script #29834
Generate external transform wrappers using a script #29834
Changes from 43 commits
f80f1ac
2517445
e5bf704
9295861
1ec6c11
f9bbf42
6a2d3d2
23450fd
01dbc63
0bc4ff4
390d8f8
45a71ea
8847562
18a157d
c64d75b
7049f80
ddd5b2f
91fe758
29d50ac
fc739fd
3f843dd
4347cd4
8093519
1c8a17f
f33e3f8
da03ff3
c356ba8
2690d0a
0b6827a
cf04b3d
a20e2a3
2bd52e8
cc60dfd
6672d61
7d81370
1c8cafc
fe02266
37d844e
dcc37fa
346346f
3da5f1f
d1f103e
92664fb
11fbd99
51c2086
19358f0
128fdbc
1c32d2a
9cb5a98
a20154d
f28b053
da8d51d
538b40a
27b7f6a
889b17c
5dd9477
9568de5
1f49d75
bdf290f
c96ade5
082295d
28146bd
5f9a227
06d5fd5
e42b3fe
0d11059
c1b29f3
620344c
8fdb02a
35da8b9
bc43578
89e139e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe _generated_external_transforms, just to be very clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest
apache_beam/transforms/xlang/
; then, docstrings will surface in pydoc; i think it is also fine to import fromapache_beam.transforms.xlang
directly, without having to reason whichapache_beam.io.
subpackage has the transform.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(but importing from
apache_beam.io
can be allowed as well )There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should discourage importing from apache_beam.transforms.xlang, as this is an implementation detail that users should not have to worry about (and may change in the future).