Allow large timestamp skew for at-least-once streaming #29858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @bvolpato |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
ahmedabu98
changed the title
bvolpato
reviewed
Dec 21, 2023
Comment on lines
1168
to
1171
| @Override | ||
| public Duration getAllowedTimestampSkew() { | ||
| return Duration.millis(Long.MAX_VALUE); | ||
| } |
There was a problem hiding this comment.
StorageApiWritesShardedRecords has
@Override
public Duration getAllowedTimestampSkew() {
return Duration.millis(BoundedWindow.TIMESTAMP_MAX_VALUE.getMillis());
}
I think the semantics are the same, just to confirm
There was a problem hiding this comment.
Yup that value is equal to Long.MAX_VALUE
There was a problem hiding this comment.
can we keep the consistency?
ahmedabu98
commented
Dec 26, 2023
| AppendRowsRequest.MissingValueInterpretation missingValueInterpretation) { | ||
| return new BigQueryServices.StreamAppendClient() { | ||
| @Override | ||
| public ApiFuture<AppendRowsResponse> appendRows(long offset, ProtoRows rows) { |
There was a problem hiding this comment.
This is the call made to send rows to BQ. It returns an ApiFuture that may contain an exception. Here we force it to always return the exception and expect the connector to handle this properly
|
R: @bvolpato do you ming taking another look? I added a test |
bvolpato
approved these changes
Dec 26, 2023
liferoad
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We maintain a buffer of element values and their timestamps, then flush when necessary (e.g. after reaching some max num elements). By the time we're forced to flush, we arrive at an element E with a timestamp potentially greater than some/most of the elements we have in the buffer. When we flush and some elements fail, we attempt to output them with their original timestamps, which may be earlier than the timestamp of the current element we are processing. Doing so triggers the following error:
Failed to insert row and could not parse the result!java.lang.IllegalArgumentException: Cannot output with timestamp 2023-12-18T20:26:27.376Z. Output timestamps must be no earlier than the timestamp of the current input or timer (2023-12-18T20:26:31.252Z) minus the allowed skew (0 milliseconds) and no later than 294247-01-10T04:00:54.775Z. See the DoFn#getAllowedTimestampSkew() Javadoc for details on changing the allowed skew.To mitigate this, we should allow a large timestamp skew.