Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vendored grpc 1.60.1 #30069

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Use vendored grpc 1.60.1 #30069

merged 1 commit into from
Jan 23, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jan 22, 2024

Fixes #29861

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Jan 23, 2024

PreCommit Java failed three times for different tests:

  1. https://github.com/apache/beam/runs/20747937439
    1. testMetrics (org.apache.beam.runners.fnexecution.control.RemoteExecutionTest) failed
  2. https://github.com/apache/beam/runs/20751137615
    1. testMultipleClientsFailingIsHandledGracefullyByServer (org.apache.beam.runners.fnexecution.logging.GrpcLoggingServiceTest) failed
  3. https://github.com/apache/beam/runs/20754788594
    1. testSplit (org.apache.beam.runners.fnexecution.control.RemoteExecutionTest) failed
    2. testMultipleClientsFailingIsHandledGracefullyByServer (org.apache.beam.runners.fnexecution.logging.GrpcLoggingServiceTest) failed

@Abacn
Copy link
Contributor Author

Abacn commented Jan 23, 2024

I could not reproduce testMultipleClientsFailingIsHandledGracefullyByServer fail locally. tests passed multiple times (set test { outputs.upToDateWhen {false} })

This is a known flaky test: #30056 without this change it is also flaky. Most likely timing issues on GHA runner. Mark as ready for review.

@Abacn
Copy link
Contributor Author

Abacn commented Jan 23, 2024

R: @m-trieu @chamikaramj

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@m-trieu m-trieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you!

@Abacn Abacn merged commit 7728558 into apache:master Jan 23, 2024
36 checks passed
@Abacn Abacn deleted the usevendorgrpc branch January 23, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade vendored beam-vendor-grpc-1_54_0 to eliminate vulnerability from shaded Netty
2 participants