[Python] Add an option to retain timestamp returned from the BigTable row #30088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riteshghorse
force-pushed
the
bigtable-handler
branch
from
6a67ab3
to
9430a81
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Checks failed because of #30095 |
|
R: @damccorm |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
damccorm
reviewed
Jan 24, 2024
sdks/python/apache_beam/transforms/enrichment_handlers/bigtable.py
Outdated
Show resolved
Hide resolved
riteshghorse
changed the title
damccorm
approved these changes
Jan 24, 2024
|
Thanks for the quick review! Once the postcommit finishes, I'll remove the trigger file and fix the lint (one import order) |
|
SGTM |
|
SGTM, thanks |
|
BigTable tests are passing - https://github.com/apache/beam/actions/runs/7642966098/job/20823850722?pr=30088. Failure are because of BigQueryIO tests(#30095) - 
|
damccorm
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to return timestamp associated with the fetched value from the BigTable read_row instead of just the value. This could be useful for users when they want to get a series of historical data stored for that key.
By default, though, only the latest value without timestamp is fetched.
Part of #29787
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.