Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust transform-service module names and deps with sdks/java/core #30237

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

kennknowles
Copy link
Member

This is a piece of #29924 that adjusts dependencies slightly and is separable from the main change.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@kennknowles
Copy link
Member Author

R: @chamikaramj since you have context on the series of adjustments.

This one got really small because actually the changes come with the bigger PR, but still since I've prepared it might as well merge now.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor

Abacn commented Feb 6, 2024

There was a recent change #30190 might need to change here as well:

automaticModuleName: 'org.apache.beam.sdk.transform.service.app',

@chamikaramj
Copy link
Contributor

+1 for also updating

automaticModuleName: 'org.apache.beam.sdk.transform.service.app',

@kennknowles
Copy link
Member Author

Done

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennknowles kennknowles merged commit 13a7084 into apache:master Feb 7, 2024
20 checks passed
@kennknowles kennknowles deleted the launcher branch February 7, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants