Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post-commit failure after pr/30205. #30331

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

shunping
Copy link
Contributor

@shunping shunping commented Feb 15, 2024

The PR #30205 introduced a bug of early termination when there is any exception in batch copy/delete. As a result, the error code is not propagated correctly and one of our post-commit tests failed.

AssertionError: BeamIOError not raised
self = <apache_beam.io.gcp.gcsfilesystem_integration_test.GcsFileSystemIntegrationTest testMethod=test_rename_error>

    @pytest.mark.it_postcommit
    def test_rename_error(self):
      num_copies = 10
      srcs = [self.INPUT_FILE] * num_copies
      dests = [
          self.gcs_tempdir + '/%s_%d' % (self.INPUT_FILE, i)
          for i in range(num_copies)
      ]
      self.fs.copy(srcs, dests)
      new_names = [
          self.gcs_tempdir + '/%s_%d' % ("renamed", i) for i in range(num_copies)
      ]
      # corrupt one of the destination names
      bad_name = self.gcs_tempdir + '/errorbadwrong'
      dests[int(num_copies / 2)] = bad_name
>     with self.assertRaises(BeamIOError):
E     AssertionError: BeamIOError not raised

apache_beam/io/gcp/gcsfilesystem_integration_test.py:127: AssertionError

addresses #28398


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@shunping
Copy link
Contributor Author

cc'ed @Abacn

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.
R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn Abacn merged commit 52eedb2 into apache:master Feb 15, 2024
70 checks passed
@shunping shunping deleted the fix-post-commit-after-pr-30205 branch February 16, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants