Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use isolated builds when building an sdist for a pipeline package supplied in --setup_file option. #31070

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Apr 22, 2024

Starting from Apache Beam 2.52.0, building a pipeline package provided in the --setup_file pipeline option happens inside an isolated build environment, which requires downloading setuptools >= 40.8.0 at pipeline submission time.

Using isolated builds requires internet connection, which might otherwise not be necessary and not available in some scenarios.

This PR will fix the issue staring from Beam 2.56.0. Affected users could work around the issue by either:

  1. uninstalling 'build' dependency in the pipeline submission environment OR
  2. installing their pipeline package in a custom container using the --sdk_container_image pipeline option or by building the package manually and passing it using the --extra_package option instead of using the --setup_file pipeline option.

@tvalentyn
Copy link
Contributor Author

R: @damccorm

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn
Copy link
Contributor Author

Will update CHANGES.md to call out a known issue in a separate PR.

@tvalentyn tvalentyn changed the title Don't use isolated builds when building an sdist. Don't use isolated builds when building an sdist for a pipeline package supplied in --setup_file option. Apr 22, 2024
@tvalentyn tvalentyn merged commit 718af0d into apache:master Apr 22, 2024
71 of 72 checks passed
tvalentyn added a commit that referenced this pull request Apr 22, 2024
@tvalentyn tvalentyn added this to the 2.56.0 Release milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants