-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ManagedIO] pass underlying transform URN as an annotation #31398
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #31398 +/- ##
============================================
+ Coverage 68.55% 71.17% +2.62%
+ Complexity 14921 2996 -11925
============================================
Files 2636 1068 -1568
Lines 222092 133696 -88396
Branches 11826 3245 -8581
============================================
- Hits 152250 95164 -57086
+ Misses 63647 35400 -28247
+ Partials 6195 3132 -3063
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/external_transforms.proto
Show resolved
Hide resolved
sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/PTransformTranslation.java
Show resolved
Hide resolved
sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/PTransformTranslation.java
Outdated
Show resolved
Hide resolved
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
…ssing transform_identifier; add unit tests for annotations
Thanks for the review @chamikaramj, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
FYI @chamikaramj, I had to move the test out of |
Test failures are unrelated |
No description provided.