Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ManagedIO] pass underlying transform URN as an annotation #31398

Merged
merged 9 commits into from
May 30, 2024

Conversation

ahmedabu98
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the java label May 24, 2024
@ahmedabu98 ahmedabu98 changed the title [ManagedIO] pass underlying transform URN to annotation [ManagedIO] pass underlying transform URN as an annotation May 24, 2024
@github-actions github-actions bot added the model label May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.17%. Comparing base (1f63196) to head (974dcb7).
Report is 53 commits behind head on master.

Current head 974dcb7 differs from pull request most recent head 8de4529

Please upload reports for the commit 8de4529 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #31398      +/-   ##
============================================
+ Coverage     68.55%   71.17%   +2.62%     
+ Complexity    14921     2996   -11925     
============================================
  Files          2636     1068    -1568     
  Lines        222092   133696   -88396     
  Branches      11826     3245    -8581     
============================================
- Hits         152250    95164   -57086     
+ Misses        63647    35400   -28247     
+ Partials       6195     3132    -3063     
Flag Coverage Δ
java 69.45% <ø> (+3.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@chamikaramj chamikaramj added this to the 2.57.0 Release milestone May 28, 2024
…ssing transform_identifier; add unit tests for annotations
@ahmedabu98
Copy link
Contributor Author

ahmedabu98 commented May 28, 2024

Thanks for the review @chamikaramj, PTAL

Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@ahmedabu98
Copy link
Contributor Author

FYI @chamikaramj, I had to move the test out of core because it required a dependency on managed, which results in a circular dependency.

@ahmedabu98
Copy link
Contributor Author

Test failures are unrelated

@ahmedabu98 ahmedabu98 merged commit b50ad0f into apache:master May 30, 2024
108 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants