-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic throttling metrics namespace and BigtableIO write throttling counter #31924
Conversation
before - agressively scale up until get completely stuck, then no longer scale up because average CPU usage below 5%, until get cancelled after - multiple scale down event though there are some caveat
|
* Introduce a generic throttling namespace and counter * Dataflow accumulates throttling time from generic throttling counter * Apply throttling counter to BigtableIO write
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Java PreCommit failed twice different tests failing, not related to this PR run#1 testIsAvailableAlwaysWakenUp (org.apache.beam.runners.flink.translation.wrappers.streaming.io.source.unbounded.FlinkUnboundedSourceReaderTest) failed testLatencyAttributionToCommittingState[0: [streamingEngine=false]] (org.apache.beam.runners.dataflow.worker.StreamingDataflowWorkerTest) failed run#2 testMultipleClientsFailingIsHandledGracefullyByServer (org.apache.beam.runners.fnexecution.logging.GrpcLoggingServiceTest) failed |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions but overall LGTM
...a/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
Show resolved
Hide resolved
...a/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
Outdated
Show resolved
Hide resolved
* Revert BigtableIO change in #31924 * Exclude fixes not related to throttling counter change * issue warning for removed configs
Fix #19632
Introduce a namepace named "beam-throttling-metrics", put under java core's Metrics.java, and use this namespace for Dataflow worker
Currently, Dataflow worker only considers several "known" namespace for throttling metrics, including bigquery streaming inserts, etc. After this change, "beam-throttling-metrics" is added to known namespace for batch Dataflow worker; and streaming dataflow worker will react on all counters named "throttliing-msecs"
Introduce a generic throttling namespace and counter
Dataflow accumulates throttling time from generic throttling counter
Apply throttling counter to BigtableIO write
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.