Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#31991][prism] Allow Empty Composites #32024

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

lostluck
Copy link
Contributor

Allows composites that only do SDK Side PCollection graph manipulation.

These composites have no payload, or subtransforms, so there's nothing for a runner to do with
them for execution. Simply ignore them.

This allows 3 Java validates runner tests in PipelineTest to pass: testIdentityTransform, testTupleProjectionTransform, and testTupleInjectionTransform.

Fixes #31991


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 56.91%. Comparing base (ffae5b5) to head (7eb43fe).
Report is 12 commits behind head on master.

Files Patch % Lines
...m/runners/prism/internal/jobservices/management.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #32024      +/-   ##
============================================
- Coverage     56.92%   56.91%   -0.01%     
  Complexity     1474     1474              
============================================
  Files           961      961              
  Lines        151462   151469       +7     
  Branches       1076     1076              
============================================
- Hits          86215    86213       -2     
- Misses        63065    63071       +6     
- Partials       2182     2185       +3     
Flag Coverage Δ
go 34.60% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lostluck
Copy link
Contributor Author

R: @damondouglas

We don't allow expressing this in the Go SDK so no coverage is possible here. Covered by the Java tests.

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damondouglas damondouglas self-requested a review July 30, 2024 20:01
@damondouglas damondouglas merged commit 121ac71 into apache:master Jul 30, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants