Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing ProtoSchemaTranslator on proto3 optional fields #32216

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

udayaw
Copy link
Contributor

@udayaw udayaw commented Aug 16, 2024

I found that ProtoSchemaTranslator fails to translate the schema when proto3 definitions have optional fields.

These optional fields creates synthetic oneOfs internally and ProtoSchemaTranslator runs into errors treating them are real oneOfs. This excludes that from happening.

I had to use getRealContainingOneof() since they have deprecated isSynthetic()

Fixes #32199


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@udayaw
Copy link
Contributor Author

udayaw commented Aug 16, 2024

Run Java PreCommit

@udayaw
Copy link
Contributor Author

udayaw commented Aug 16, 2024

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

Reminder, please take a look at this pr: @Abacn

@Abacn
Copy link
Contributor

Abacn commented Aug 27, 2024

testWithResume (org.apache.beam.runners.spark.translation.streaming.ResumeFromCheckpointStreamingTest) failed

failed 3 times, but not likely related to this change. Checked out the PR and the test passed locally:

Test	Duration	Result
testWithResume	19.628s	passed

@Abacn Abacn merged commit d1157d8 into apache:master Aug 27, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ProtoMessageSchema.getSchema fails on proto3 messages with optional fields
2 participants