Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to runinference #32237

Merged
merged 13 commits into from
Aug 21, 2024
Merged

Add timeout to runinference #32237

merged 13 commits into from
Aug 21, 2024

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Aug 19, 2024

Add/expose a timeout in RunInference. This follows the path laid out in https://docs.google.com/document/d/19ves6iv-m_6DFmePJZqYpLm-bCooPu6wQ-Ti6kAl2Jo/edit to add a timeout option to RunInference so that it can be timed out and still perform garbage collection

Part of #32137


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm damccorm changed the title [WIP] Add timeout to runinference Add timeout to runinference Aug 21, 2024
@damccorm damccorm marked this pull request as ready for review August 21, 2024 12:55
@damccorm
Copy link
Contributor Author

R: @jrmccluskey

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things to clean up and clarify as far as documentation

sdks/python/apache_beam/ml/inference/base.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/ml/inference/base.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/ml/inference/base.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/ml/inference/base.py Show resolved Hide resolved
sdks/python/apache_beam/ml/inference/base.py Outdated Show resolved Hide resolved
@damccorm damccorm merged commit b873be8 into master Aug 21, 2024
87 checks passed
@damccorm damccorm deleted the users/damccorm/timeout-cb branch August 21, 2024 16:10
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 88.11881% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.10%. Comparing base (8601bba) to head (a0dc73c).
Report is 13 commits behind head on master.

Files Patch % Lines
sdks/python/apache_beam/ml/inference/base.py 88.11% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #32237      +/-   ##
============================================
+ Coverage     77.96%   78.10%   +0.14%     
  Complexity     3023     3023              
============================================
  Files           750      751       +1     
  Lines         96303    96465     +162     
  Branches       3301     3301              
============================================
+ Hits          75084    75348     +264     
+ Misses        19702    19600     -102     
  Partials       1517     1517              
Flag Coverage Δ
python 81.62% <88.11%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Abacn
Copy link
Contributor

Abacn commented Aug 28, 2024

@damccorm
Copy link
Contributor Author

Thanks - that test relies on timing, and it seems like its only broken on windows (and very rarely). So I'm not too worried its a real problem, I'll see if I can modify the test though

@damccorm damccorm mentioned this pull request Aug 28, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants