Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RunInference GC to finalize_bundle #32281

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Move RunInference GC to finalize_bundle #32281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions sdks/python/apache_beam/ml/inference/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1795,16 +1795,6 @@ def process(
side input is empty or the model has not been updated, the method
simply runs inference on the batch of data.
"""
# Do garbage collection of old models before starting inference.
tags_to_gc = self._model_metadata.get_tags_for_garbage_collection()
if len(tags_to_gc) > 0:
for unprefixed_tag in tags_to_gc:
for tag in _get_tags_for_copies(unprefixed_tag,
self._model_handler.model_copies()):
multi_process_shared.MultiProcessShared(lambda: None,
tag).unsafe_hard_delete()
self._model_metadata.mark_tags_deleted(tags_to_gc)

if not si_model_metadata:
if (not self._model_metadata.is_valid_tag(self._cur_tag) or
self._model is None):
Expand Down Expand Up @@ -1834,6 +1824,16 @@ def finish_bundle(self):
if self._metrics_collector:
self._metrics_collector.update_metrics_with_cache()

# Do garbage collection of old models
tags_to_gc = self._model_metadata.get_tags_for_garbage_collection()
if len(tags_to_gc) > 0:
for unprefixed_tag in tags_to_gc:
for tag in _get_tags_for_copies(unprefixed_tag,
self._model_handler.model_copies()):
multi_process_shared.MultiProcessShared(lambda: None,
tag).unsafe_hard_delete()
self._model_metadata.mark_tags_deleted(tags_to_gc)


def _is_darwin() -> bool:
return sys.platform == 'darwin'
Expand Down
Loading