-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the python deps #32756
Update the python deps #32756
Conversation
cc @jrmccluskey |
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Reminder, please take a look at this pr: @damccorm |
We will pin protobuf==4.25.5 for now with Beam 2.61.0. |
cc @Abacn later I will polish this PR to update the deps. FYI. |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
|
stop reviewer notifications |
Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Given how close we are to the release cut, I would keep the dependency changes to a minimum or do this update after the release cut. |
For example, if there is a regression in google-api-core==2.22.0, we have only two weeks to notice that. |
@damccorm what do you think? I am fine to do this after 2.61.0. |
Its borderline, but I probably agree waiting is safer. I don't think we need to do this for the current release |
Rebased. Based on the discussions, we should get this in ASAP after 2.61.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/apache/beam/actions/workflows/beam_PreCommit_Python_Coverage.yml, https://github.com/apache/beam/actions/workflows/beam_PreCommit_Python_ML.yml, are also read on the master. My PR is not related to these failed workflows. |
Fixes #32681
Beam does not directly depend on numpy 2.0.
Following https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-HowtoupdatedependenciesthatareinstalledinPythoncontainerimages:
and https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-InstallingPythoninterpreters, updated the base image deps.
Pin protobuf to 4.25.5 and grpcio-status to 1.62.3 since some ML packages (TF) still depend on protobuf 4.x
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.