[Improvement] Removed unused/non-updated objects

apache · Jun 25, 2024 · c649748 · c649748
1 parent e200aa3
commit c649748
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 9 deletions.
diff --git a/stream/distributedlog/core/src/main/java/org/apache/distributedlog/LocalDLMEmulator.java b/stream/distributedlog/core/src/main/java/org/apache/distributedlog/LocalDLMEmulator.java
@@ -61,7 +61,6 @@ public class LocalDLMEmulator {
 
     private final String zkEnsemble;
     private final URI uri;
-    private final List<File> tmpDirs = new ArrayList<File>();
     private final int zkTimeoutSec;
     private final Thread bkStartupThread;
     private final String zkHost;
@@ -180,9 +179,6 @@ public void teardown() throws Exception {
             bkStartupThread.interrupt();
             bkStartupThread.join();
         }
-        for (File dir : tmpDirs) {
-            FileUtils.forceDeleteOnExit(dir);
-        }
     }
 
     public String getZkServers() {

diff --git a/...dlog/core/src/main/java/org/apache/distributedlog/config/DynamicConfigurationFactory.java b/...dlog/core/src/main/java/org/apache/distributedlog/config/DynamicConfigurationFactory.java
@@ -49,7 +49,6 @@ public class DynamicConfigurationFactory {
     private static final Logger LOG = LoggerFactory.getLogger(DynamicConfigurationFactory.class);
 
     private final Map<String, DynamicDistributedLogConfiguration> dynamicConfigs;
-    private final List<ConfigurationSubscription> subscriptions;
     private final ScheduledExecutorService executorService;
     private final int reloadPeriod;
     private final TimeUnit reloadUnit;
@@ -60,7 +59,6 @@ public DynamicConfigurationFactory(ScheduledExecutorService executorService,
         this.reloadPeriod = reloadPeriod;
         this.reloadUnit = reloadUnit;
         this.dynamicConfigs = new HashMap<String, DynamicDistributedLogConfiguration>();
-        this.subscriptions = new LinkedList<ConfigurationSubscription>();
     }
 
     public synchronized Optional<DynamicDistributedLogConfiguration> getDynamicConfiguration(
@@ -77,7 +75,6 @@ public synchronized Optional<DynamicDistributedLogConfiguration> getDynamicConfi
                 List<FileConfigurationBuilder> fileConfigBuilders = Lists.newArrayList(properties);
                 ConfigurationSubscription subscription = new ConfigurationSubscription(
                         dynConf, fileConfigBuilders, executorService, reloadPeriod, reloadUnit);
-                subscriptions.add(subscription);
                 dynamicConfigs.put(configPath, dynConf);
                 LOG.info("Loaded dynamic configuration at {}", configPath);
             }

diff --git a/...tests-topologies/src/main/java/org/apache/bookkeeper/tests/containers/ChaosContainer.java b/...tests-topologies/src/main/java/org/apache/bookkeeper/tests/containers/ChaosContainer.java
@@ -85,7 +85,6 @@ public void tailContainerLog() {
     }
 
     public String getContainerLog() {
-        StringBuilder sb = new StringBuilder();
 
         LogContainerCmd logContainerCmd = this.dockerClient.logContainerCmd(this.getContainerId());
         logContainerCmd.withStdOut(true).withStdErr(true);
@@ -94,7 +93,7 @@ public String getContainerLog() {
         } catch (InterruptedException e) {
 
         }
-        return sb.toString();
+        return "";
     }
 
     public ExecResult execCmd(String... cmd) throws Exception {