Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky-test: HandleFailuresTest.testHandleFailureBookieNotInWriteSet #4109

Closed
AnonHxy opened this issue Oct 18, 2023 · 0 comments
Closed

Flaky-test: HandleFailuresTest.testHandleFailureBookieNotInWriteSet #4109

AnonHxy opened this issue Oct 18, 2023 · 0 comments
Labels
area/tests flaky-tests

Comments

@AnonHxy
Copy link
Contributor

AnonHxy commented Oct 18, 2023

HandleFailuresTest.testHandleFailureBookieNotInWriteSet is flaky. It fails sporadically.

Error:  org.apache.bookkeeper.client.HandleFailuresTest.testHandleFailureBookieNotInWriteSet  Time elapsed: 30.008 s  <<< ERROR!
org.junit.runners.model.TestTimedOutException: test timed out after 30000 milliseconds
	at java.base@11.0.20.1/jdk.internal.misc.Unsafe.park(Native Method)
	at java.base@11.0.20.1/java.util.concurrent.locks.LockSupport.park(LockSupport.java:194)
	at java.base@11.0.20.1/java.util.concurrent.CompletableFuture$Signaller.block(CompletableFuture.java:1796)
	at java.base@11.0.20.1/java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3128)
	at java.base@11.0.20.1/java.util.concurrent.CompletableFuture.waitingGet(CompletableFuture.java:1823)
	at java.base@11.0.20.1/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1998)
	at app//org.apache.bookkeeper.client.HandleFailuresTest.testHandleFailureBookieNotInWriteSet(HandleFailuresTest.java:484)
	at java.base@11.0.20.1/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base@11.0.20.1/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base@11.0.20.1/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base@11.0.20.1/java.lang.reflect.Method.invoke(Method.java:566)
	at app//org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at app//org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at app//org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at app//org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at app//org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at app//org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:[292](https://github.com/apache/bookkeeper/actions/runs/6438330917/job/17597911178?pr=4098#step:8:293))
	at java.base@11.0.20.1/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base@11.0.20.1/java.lang.Thread.run(Thread.java:829)
@AnonHxy AnonHxy mentioned this issue Oct 18, 2023
Merged
zymap pushed a commit that referenced this issue Dec 4, 2023
@AnonHxy
issue 4109: Fix Flaky-test: HandleFailuresTest.testHandleFailureBooki…
b3662b7 
…eNotInWriteSet (#4110)

Master Issue: #4109
### Motivation

Fix Flaky-test: HandleFailuresTest.testHandleFailureBookieNotInWriteSet

When we call `b1Delay.completeExceptionally(new BKException.BKWriteException())` at line480(code1),  the `preWriteHook` will complete with exception  and then do some actions in the choosen thread(code2), e.g., put the failure bookie to `delayedWriteFailedBookies`(code3).  So the `delayedWriteFailedBookies` update is async.

However, `lh.appendAsync("entry2".getBytes()))`(Line483 in Code4) is invoked in main thread. So when `appendAsync` execute,  the `delayedWriteFailedBookies` could be not updated yet, and `changeInProgress.complete(null)`(code5) will never be invoked.
yangl pushed a commit to yangl/bookkeeper that referenced this issue Dec 11, 2023
@AnonHxy @yangl
issue 4109: Fix Flaky-test: HandleFailuresTest.testHandleFailureBooki…
ba0a8b0 
…eNotInWriteSet (apache#4110)

Master Issue: apache#4109
### Motivation

Fix Flaky-test: HandleFailuresTest.testHandleFailureBookieNotInWriteSet

When we call `b1Delay.completeExceptionally(new BKException.BKWriteException())` at line480(code1),  the `preWriteHook` will complete with exception  and then do some actions in the choosen thread(code2), e.g., put the failure bookie to `delayedWriteFailedBookies`(code3).  So the `delayedWriteFailedBookies` update is async.

However, `lh.appendAsync("entry2".getBytes()))`(Line483 in Code4) is invoked in main thread. So when `appendAsync` execute,  the `delayedWriteFailedBookies` could be not updated yet, and `changeInProgress.complete(null)`(code5) will never be invoked.
hangc0276 pushed a commit to hangc0276/bookkeeper that referenced this issue Jan 18, 2024
@AnonHxy @hangc0276
issue 4109: Fix Flaky-test: HandleFailuresTest.testHandleFailureBooki…
db6d997 
…eNotInWriteSet (apache#4110)

Master Issue: apache#4109
### Motivation

Fix Flaky-test: HandleFailuresTest.testHandleFailureBookieNotInWriteSet

When we call `b1Delay.completeExceptionally(new BKException.BKWriteException())` at line480(code1),  the `preWriteHook` will complete with exception  and then do some actions in the choosen thread(code2), e.g., put the failure bookie to `delayedWriteFailedBookies`(code3).  So the `delayedWriteFailedBookies` update is async.

However, `lh.appendAsync("entry2".getBytes()))`(Line483 in Code4) is invoked in main thread. So when `appendAsync` execute,  the `delayedWriteFailedBookies` could be not updated yet, and `changeInProgress.complete(null)`(code5) will never be invoked.

(cherry picked from commit b3662b7)
Ghatage pushed a commit to sijie/bookkeeper that referenced this issue Jul 12, 2024
@AnonHxy
issue 4109: Fix Flaky-test: HandleFailuresTest.testHandleFailureBooki…
b0ba8c9 
…eNotInWriteSet (apache#4110)

Master Issue: apache#4109
### Motivation

Fix Flaky-test: HandleFailuresTest.testHandleFailureBookieNotInWriteSet

When we call `b1Delay.completeExceptionally(new BKException.BKWriteException())` at line480(code1),  the `preWriteHook` will complete with exception  and then do some actions in the choosen thread(code2), e.g., put the failure bookie to `delayedWriteFailedBookies`(code3).  So the `delayedWriteFailedBookies` update is async.

However, `lh.appendAsync("entry2".getBytes()))`(Line483 in Code4) is invoked in main thread. So when `appendAsync` execute,  the `delayedWriteFailedBookies` could be not updated yet, and `changeInProgress.complete(null)`(code5) will never be invoked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tests flaky-tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hangc0276 @AnonHxy