Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 2655 bookie will be down (out of memory), when there are a lots of ledgers under /ledgers/underreplication/ledgers to replication #2672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baomingyu
Copy link

Descriptions of the changes in this PR:

Motivation

In some exception branch, lh is not be unregister from listener, so I make this change.

Changes

if (rc != BKException.Code.OK) {
if (lh != null && !doRecovery) {
bk.getClientCtx().getLedgerManager()
.unregisterLedgerMetadataListener(ledgerId, lh);
}
openComplete(bk.getReturnRc(BKException.Code.ReadException), null);
}

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for providing your fix.
The fix makes sense to me.

From my point of view it is hard to see how this fix is related to the original problem.
do you have any log, memory dump... or any other hint that points into this direction ?

@baomingyu
Copy link
Author

thanks for providing your fix.
The fix makes sense to me.

From my point of view it is hard to see how this fix is related to the original problem.
do you have any log, memory dump... or any other hint that points into this direction ?

This scene is realy hard to see, In my scene , I change 3 3 2 to 2 2 2 , and replicaiton will mark this scene .

my dump file in mat
image

@StevenLuMT
Copy link
Member

fix old workflow,please see #3455 for detail

@shoothzj
Copy link
Member

shoothzj commented May 2, 2024

@baomingyu Thanks for your contribution, could you please update this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants