[Security] Upgrade libthrift to 0.14.2 to address multiple CVEs #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
May 3, 2021
lhotari
force-pushed
the
lh-upgrade-libthrift
branch
2 times, most recently
from
e0422a9 to
48aaf58
Compare
dlg99
requested changes
May 27, 2021
There was a problem hiding this comment.
@lhotari @eolivelli I debugged through the test failures and traced the rootcause to https://issues.apache.org/jira/browse/THRIFT-5383 fixed in apache/thrift#2366
We'll need libthrift 0.15.0 (or 0.14.2, if that happens). Json Parsing in 0.14.0 and 0.14.1 is completely broken.
|
I added https://issues.apache.org/jira/browse/THRIFT-5424 - mailing lists didn't seem active (outside of auto posts from jira) |
lhotari
changed the title
lhotari
changed the title
lhotari
force-pushed
the
lh-upgrade-libthrift
branch
from
48aaf58 to
635bb54
Compare
|
@dlg99 can you please take another look? |
|
@lhotari Thanks for the PR. When I tried to cherry-pick it to branch-4.14, I got a conflict. To be safe, I have not tried to resolve it, could you submit another PR for branch-4.14? |
lhotari
added a commit
to lhotari/bookkeeper
that referenced
this pull request
Aug 13, 2021
Fixes apache#2512 ### Motivation See apache#2512 The current libthrift version 0.12.0 has multiple vulnerabilities: - CVE-2019-0205 , CVE-2019-0210 , CVE-2020-13949 ### Motivation - Upgrade libthrift version to 0.14.1 and fix compilation errors - exclude new transitive dependencies org.apache.tomcat.embed:tomcat-embed-core and javax.annotation:javax.annotation-api Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Andrey Yegorov <None> This closes apache#2695 from lhotari/lh-upgrade-libthrift (cherry picked from commit ea08e6d)
fpj
pushed a commit
that referenced
this pull request
Aug 13, 2021
…port to branch-4.14) ### Motivation backport #2695 to branch-4.14 Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Flavio Junqueira <None> This closes #2762 from lhotari/lh-upgrade-libthrift-4.14 and squashes the following commits: 79b78b6 [Lari Hotari] [SECURITY] Upgrade libthrift to 0.14.2 to address multiple CVEs 69360e1 [Enrico Olivelli] Fix tests pom, set version to 4.14.1-SNAPSHOT e54be34 [Jia Zhai] Fix Bouncy Castle fips incompatible issue (#2740) 4c078bb [Matteo Merli] [maven-release-plugin] rollback changes from release preparation of v4.14.1-rc0 f7a9442 [Matteo Merli] [maven-release-plugin] prepare release v4.14.1-rc0 4292db8 [hangc0276] fix prometheus metric provider bug and add test to cover label scope … 12f0f5f [Matteo Merli] Version 4.14.1-SNAPSHOT 4acca53 [Andrey Yegorov] Include gradle files into the source artifact for releases, exclude site2/** f24bef6 [Andrey Yegorov] [maven-release-plugin] rollback changes from release preparation of v4.14.0-rc0 4729682 [Andrey Yegorov] [maven-release-plugin] prepare release v4.14.0-rc0
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Fixes apache#2512 ### Motivation See apache#2512 The current libthrift version 0.12.0 has multiple vulnerabilities: - CVE-2019-0205 , CVE-2019-0210 , CVE-2020-13949 ### Motivation - Upgrade libthrift version to 0.14.1 and fix compilation errors - exclude new transitive dependencies org.apache.tomcat.embed:tomcat-embed-core and javax.annotation:javax.annotation-api Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Andrey Yegorov <None> This closes apache#2695 from lhotari/lh-upgrade-libthrift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2512
Motivation
See #2512
The current libthrift version 0.12.0 has multiple vulnerabilities:
Motivation