Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Vulnerabilities in CentOS 7 image, Upgrade image to CentOS 8… #2756

Closed
wants to merge 1 commit into from

Conversation

gaddamas
Copy link

Security Vulnerabilities in CentOS 7 image, Upgrade image to CentOS 8 #2746

Descriptions of the changes in this PR:
Update base image to CentOS 8

Motivation

(Explain: why you're making that change, what is the problem you're trying to solve)
Fix security vulnerabilities.

Changes

(Describe: what changes you have made)

Master Issue: #


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gaddamas
Copy link
Author

gaddamas commented Jul 26, 2021

Failure on integration test:
[ERROR] Failed to execute goal on project metadata-stores-etcd: Could not resolve dependencies for project org.apache.bookkeeper.metadata.drivers:metadata-stores-etcd:jar:4.15.0-SNAPSHOT: The following artifacts could not be resolved: org.apache.bookkeeper:bookkeeper-server:jar:4.15.0-SNAPSHOT, org.apache.bookkeeper:bookkeeper-common:jar:tests:4.15.0-SNAPSHOT, org.apache.bookkeeper:bookkeeper-server:jar:tests:4.15.0-SNAPSHOT: org.apache.bookkeeper:bookkeeper-server:jar:4.15.0-SNAPSHOT was not found in https://repository.apache.org/snapshots during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of apache.snapshots has elapsed or updates are forced -> [Help 1]

https://repository.apache.org/content/groups/snapshots/org/apache/bookkeeper/metadata/drivers/metadata-stores-etcd/

@eolivelli
Copy link
Contributor

I have restarted the job

@lhotari can you please take a look to this patch ?

@eolivelli
Copy link
Contributor

@gaddamas the patch is good to go.
We need another reviewer to validate the patch before merging it.

@sijie @fpj @merlimat @Ghatage PTAL

@eolivelli
Copy link
Contributor

@gaddamas did you try locally the new image ?

@gaddamas
Copy link
Author

@gaddamas did you try locally the new image ?

I am testing it, will not be merging until my local testing is complete.

@eolivelli
Copy link
Contributor

Thinking more about this change....
In Pulsar we switched the docker images to Ubuntu because it seems to be updated more promptly in case of security vulnerabilities.

Can we hold on in merging this patch ?
I will start a discussion on the dev@bookkeeper.apache.org mailing list

cc @lhotari you may be interesting in following this work

@eolivelli
Copy link
Contributor

@dlg99
Copy link
Contributor

dlg99 commented Feb 14, 2022

@eolivelli @gaddamas @lhotari It's been awhile. What's the consensus on the base image?

Copy link
Member

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@StevenLuMT
Copy link
Member

fix old workflow,please see #3455 for detail

@shoothzj
Copy link
Member

Now we have migrated to ubuntu, close this PR

@shoothzj shoothzj closed this Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants