Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 2784] get local host from config file #2785

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

casuallc
Copy link

@casuallc casuallc commented Sep 3, 2021

Descriptions of the changes in this PR:

#2784

Copy link
Contributor

@dlg99 dlg99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests and add new config into the default conf file with description to make the feature discoverable.

I think this might be useful for hosts with multiple network interfaces

@casuallc
Copy link
Author

Please add unit tests and add new config into the default conf file with description to make the feature discoverable.

I think this might be useful for hosts with multiple network interfaces

@dlg99 I do not think there need a new config, we just use the existed config advertisedAddress.

If we use InetAddress.getLocalHost() instead of use config advertisedAddress, there is problem.

I add more log, take a look please. #2784

@StevenLuMT
Copy link
Member

fix old workflow,please see #3455 for detail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants