zk client config update and bugfix for ZKMetadataClientDriver #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. change zkRetryBackoffMaxRetries to config 2. update a error config for BoundExponentialBackoffRetryPolicy in class ZKMetadataClientDriver
|
Very good. |
|
rerun failure checks |
|
@nicoloboschi @dlg99 @eolivelli @zymap |
|
rerun failure checks |
nicoloboschi
approved these changes
Dec 26, 2021
zymap
approved these changes
Dec 29, 2021
|
Looks like the tests have been failed multiple times. Could you please run them on your local and find what's happened? |
|
ok，I try to debug in my local project,thanks @zymap |
|
@eolivelli @zymap |
This was referenced Mar 1, 2022
Shawyeok
pushed a commit
to Shawyeok/bookkeeper
that referenced
this pull request
Oct 21, 2022
…#2958) ### Motivation 1. bug fix for error config for BoundExponentialBackoffRetryPolicy in class ZKMetadataClientDriver,if set MaxRetries zero, zk client will throw ConnectionLossException when the zk has some changing,for example: zk leader node changed. 2. In Bookie's ZKClient, different BoundExponentialBackoffRetryPolicy set different MaxRetries,so change zkRetryBackoffMaxRetries to config in Bookie's AbstractConfiguration ### Changes 1. update a error config for BoundExponentialBackoffRetryPolicy in class ZKMetadataClientDriver 2. change zkRetryBackoffMaxRetries to config Master Issue: apache#2760 (cherry picked from commit 84ddc91)
dlg99
pushed a commit
to dlg99/bookkeeper
that referenced
this pull request
Oct 24, 2022
…#2958) ### Motivation 1. bug fix for error config for BoundExponentialBackoffRetryPolicy in class ZKMetadataClientDriver,if set MaxRetries zero, zk client will throw ConnectionLossException when the zk has some changing,for example: zk leader node changed. 2. In Bookie's ZKClient, different BoundExponentialBackoffRetryPolicy set different MaxRetries,so change zkRetryBackoffMaxRetries to config in Bookie's AbstractConfiguration ### Changes 1. update a error config for BoundExponentialBackoffRetryPolicy in class ZKMetadataClientDriver 2. change zkRetryBackoffMaxRetries to config Master Issue: apache#2760 (cherry picked from commit 84ddc91)
dlg99
added a commit
to datastax/bookkeeper
that referenced
this pull request
Oct 24, 2022
zk client config update and bugfix for ZKMetadataClientDriver (apache#2958)
Shawyeok
pushed a commit
to Shawyeok/bookkeeper
that referenced
this pull request
Oct 25, 2022
…#2958) ### Motivation 1. bug fix for error config for BoundExponentialBackoffRetryPolicy in class ZKMetadataClientDriver,if set MaxRetries zero, zk client will throw ConnectionLossException when the zk has some changing,for example: zk leader node changed. 2. In Bookie's ZKClient, different BoundExponentialBackoffRetryPolicy set different MaxRetries,so change zkRetryBackoffMaxRetries to config in Bookie's AbstractConfiguration ### Changes 1. update a error config for BoundExponentialBackoffRetryPolicy in class ZKMetadataClientDriver 2. change zkRetryBackoffMaxRetries to config Master Issue: apache#2760 (cherry picked from commit 84ddc91)
|
@hangc0276 |
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Nov 7, 2022
…#2958) ### Motivation 1. bug fix for error config for BoundExponentialBackoffRetryPolicy in class ZKMetadataClientDriver,if set MaxRetries zero, zk client will throw ConnectionLossException when the zk has some changing,for example: zk leader node changed. 2. In Bookie's ZKClient, different BoundExponentialBackoffRetryPolicy set different MaxRetries,so change zkRetryBackoffMaxRetries to config in Bookie's AbstractConfiguration ### Changes 1. update a error config for BoundExponentialBackoffRetryPolicy in class ZKMetadataClientDriver 2. change zkRetryBackoffMaxRetries to config Master Issue: apache#2760 (cherry picked from commit 84ddc91)
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Nov 7, 2022
…#2958) ### Motivation 1. bug fix for error config for BoundExponentialBackoffRetryPolicy in class ZKMetadataClientDriver,if set MaxRetries zero, zk client will throw ConnectionLossException when the zk has some changing,for example: zk leader node changed. 2. In Bookie's ZKClient, different BoundExponentialBackoffRetryPolicy set different MaxRetries,so change zkRetryBackoffMaxRetries to config in Bookie's AbstractConfiguration ### Changes 1. update a error config for BoundExponentialBackoffRetryPolicy in class ZKMetadataClientDriver 2. change zkRetryBackoffMaxRetries to config Master Issue: apache#2760 (cherry picked from commit 84ddc91)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…#2958) ### Motivation 1. bug fix for error config for BoundExponentialBackoffRetryPolicy in class ZKMetadataClientDriver,if set MaxRetries zero, zk client will throw ConnectionLossException when the zk has some changing,for example: zk leader node changed. 2. In Bookie's ZKClient, different BoundExponentialBackoffRetryPolicy set different MaxRetries,so change zkRetryBackoffMaxRetries to config in Bookie's AbstractConfiguration ### Changes 1. update a error config for BoundExponentialBackoffRetryPolicy in class ZKMetadataClientDriver 2. change zkRetryBackoffMaxRetries to config Master Issue: apache#2760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
bug fix for error config for BoundExponentialBackoffRetryPolicy in class ZKMetadataClientDriver,if set MaxRetries zero, zk client will throw ConnectionLossException when the zk has some changing,for example: zk leader node changed.
In Bookie's ZKClient, different BoundExponentialBackoffRetryPolicy set different MaxRetries,so change zkRetryBackoffMaxRetries to config in Bookie's AbstractConfiguration
Changes
Master Issue: #2760