-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update datasketches version from 0.8.3 to 3.2.0 #3264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@shoothzj Can you also check the number of allocations? Using I remember in earlier versions of datasketches (after 0.8.3) they had introduced some regression that added lot of heap allocations. |
@shoothzj Just did a quick test. There are 4 bytes per each recorded sample with the new Datasketches. It would be good to understand why that is the case and if there's any way to configure DataSketches to avoid that.
|
@merlimat Sorry for my late reply, I also tested 27 days before. Also open an issue in apache/datasketches-java#398 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd better keep the old version due to the performance issue.
fix old workflow,please see #3455 for detail |
The issue has been closed |
Motivation
sketches-core
0.8.3 is released in 2016. Keep update. And it's now transfer to an apache projectChanges
update
sketches-core
to latest apache versionPerformance test (using jmh)
Performance tests doesn't show any performance regression
0.8.3
3.2.0