Add .asf.yaml for configuring the project #3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- *Motivation* Same as Pulsar, Pulsar is using [.asf.yaml](https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Branchprotection) to configure the project, like the branch protection. Add .asf.yaml for configuring the PR required CI.
zymap
requested review from
merlimat,
Vanlightly,
hangc0276,
dlg99,
eolivelli and
nicoloboschi
hangc0276
approved these changes
Aug 4, 2022
zymap
pushed a commit
that referenced
this pull request
Aug 20, 2022
Descriptions of the changes in this PR: ### Motivation using [.asf.yaml](https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Branchprotection) to configure the project, but there 's some config bugfix for project's .asf.yaml the name of workflow's jobs is not set, so #3439 causes contexts can't match check's jobs this picture is the other new add pr's running result: the other pr's workflow run abnormally <img width="923" alt="image" src="https://user-images.githubusercontent.com/42990025/185718866-b7054dd7-502f-4371-8906-c43f8b1b166b.png"> this picture is current running result: current pr is running normally because the job name is added in yaml file <img width="954" alt="image" src="https://user-images.githubusercontent.com/42990025/185718710-ec41584e-4871-40cc-9ed6-655caa7ff021.png"> ### Changes 1. add the name for checks 2. change required_approving_review_count to 2 person 3. update README.md for workflows
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
--- *Motivation* Same as Pulsar, Pulsar is using [.asf.yaml](https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Branchprotection) to configure the project, like the branch protection. Add .asf.yaml for configuring the PR required CI.
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Descriptions of the changes in this PR: ### Motivation using [.asf.yaml](https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Branchprotection) to configure the project, but there 's some config bugfix for project's .asf.yaml the name of workflow's jobs is not set, so apache#3439 causes contexts can't match check's jobs this picture is the other new add pr's running result: the other pr's workflow run abnormally <img width="923" alt="image" src="https://user-images.githubusercontent.com/42990025/185718866-b7054dd7-502f-4371-8906-c43f8b1b166b.png"> this picture is current running result: current pr is running normally because the job name is added in yaml file <img width="954" alt="image" src="https://user-images.githubusercontent.com/42990025/185718710-ec41584e-4871-40cc-9ed6-655caa7ff021.png"> ### Changes 1. add the name for checks 2. change required_approving_review_count to 2 person 3. update README.md for workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Same as Pulsar, Pulsar is using .asf.yaml to configure the project,
like the branch protection.
Add .asf.yaml for configuring the PR required CI.