Avoid extra buffer to prepend frame size #3560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
hangc0276
approved these changes
Oct 20, 2022
hangc0276
added
release/4.14.6
release/4.15.3
and removed
release/4.14.6
release/4.15.3
labels
|
please take a look to tests |
merlimat
commented
Oct 24, 2022
| @@ -481,12 +482,14 @@ public ReferenceCounted retain(int increment) { | |||
|
|
|||
| @Override | |||
| public ReferenceCounted touch() { | |||
| return data.touch(); | |||
There was a problem hiding this comment.
When using the leak checker, this was causing the ReadResponse to get converted into an instrumented buffer, and the serialization was completely skipped.
zymap
approved these changes
Oct 24, 2022
|
@merlimat Would you please take a look at those failed tests? |
yaalsn
pushed a commit
to yaalsn/bookkeeper
that referenced
this pull request
Jan 30, 2023
* Avoid extra buffer to prepend frame size * Fixed checkstyle * Fixed touch methods on ReadResponse * Fixed frame size for protobuf requests * Removed unwanted changes * Fixed AuthResponse in v2 protocol * Fixed test
hangc0276
pushed a commit
that referenced
this pull request
Feb 13, 2023
* Avoid extra buffer to prepend frame size * Fixed checkstyle * Fixed touch methods on ReadResponse * Fixed frame size for protobuf requests * Removed unwanted changes * Fixed AuthResponse in v2 protocol * Fixed test (cherry picked from commit 02be9d2)
zymap
pushed a commit
that referenced
this pull request
Feb 16, 2023
* Avoid extra buffer to prepend frame size * Fixed checkstyle * Fixed touch methods on ReadResponse * Fixed frame size for protobuf requests * Removed unwanted changes * Fixed AuthResponse in v2 protocol * Fixed test (cherry picked from commit 02be9d2)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
* Avoid extra buffer to prepend frame size * Fixed checkstyle * Fixed touch methods on ReadResponse * Fixed frame size for protobuf requests * Removed unwanted changes * Fixed AuthResponse in v2 protocol * Fixed test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As described in #3559, we should avoid the extra buffer allocation just for prepending the 4 bytes frame size