Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DefaultEntryLogger read performance. #4038

Merged
merged 13 commits into from
Feb 12, 2024
Merged

Improve DefaultEntryLogger read performance. #4038

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c2bd20b
Avoid system call to improve read performance.
horizonzy Jul 26, 2023
071c9fd
Fix ci.
horizonzy Jul 27, 2023
d27256f
Add comments for getCurrentWritingLogId
horizonzy Jul 27, 2023
f6f7b36
Fix ci.
horizonzy Jul 27, 2023
95d40a9
Consider compacting log.
horizonzy Jul 30, 2023
9d25baf
Fix checkstyle.
horizonzy Jul 30, 2023
47ed592
Address the comment.
horizonzy Jul 30, 2023
114294c
Address comment.
horizonzy Aug 1, 2023
f8a68ef
Address the comments.
horizonzy Aug 10, 2023
2b22752
Add tests.
horizonzy Sep 7, 2023
5ad1133
Fix checkstyle.
horizonzy Sep 7, 2023
f389666
address the comments.
horizonzy Feb 10, 2024
1796a4d
Fix concurrency problem.
horizonzy Feb 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedReadChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public class BufferedReadChannel extends BufferedChannelBase {

long invocationCount = 0;
long cacheHitCount = 0;
private long fileSize = -1;

public BufferedReadChannel(FileChannel fileChannel, int readCapacity) {
super(fileChannel);
Expand All @@ -64,10 +65,18 @@ public int read(ByteBuf dest, long pos) throws IOException {
return read(dest, pos, dest.writableBytes());
}

@Override
public long size() throws IOException {
if (fileSize == -1) {
fileSize = validateAndGetFileChannel().size();
}
return fileSize;
}

public synchronized int read(ByteBuf dest, long pos, int length) throws IOException {
invocationCount++;
long currentPosition = pos;
long eof = validateAndGetFileChannel().size();
long eof = size();
// return -1 if the given position is greater than or equal to the file's current size.
if (pos >= eof) {
return -1;
Expand Down
Loading